ism330dl: Use polling with timeout in _ensure_data().#128
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ISM330DL driver’s auto-trigger wakeup path to wait for data-ready via STATUS_REG polling (with a timeout) instead of using a fixed sleep_ms(100), aligning behavior with other drivers in the repository.
Changes:
- Replaced fixed delay in
ISM330DL._ensure_data()with polling ofREG_STATUS_REGforSTATUS_XLDA(up to 50×10ms) and anOSErroron timeout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 0.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125
Summary
Replace
sleep_ms(100)with polling ofSTATUS_REGforXLDAbit andOSErroron timeout, consistent with the pattern used by WSEN-HIDS, LIS2MDL, VL53L1X, and APDS9960.Test plan